Enable Scroll To Text by default #19634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1838701
branch
2 times, most recently
from
4664d81
to
66d9595
Compare
Enables scroll to text by default for M81. Note we plan to launch via Finch for M80. Intent to ship with LGTMs: https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ This patch also updates web platform test expectations: - scroll-to-text-fragment.html now passes; it just needed an extra rAF for the fallback to element anchor behavior. - scroll-to-text-fragment-security.html has two expected failures, as they need to be updated to test cross-origin navigations. I'll make this change in a follow-up patch to close bug 1042311. Bug: 919204 Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838701 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#732592}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1838701
branch
from
66d9595
to
b774cc8
Compare
|
Failed Firefox stability check due to having a slow test: This change however didn't touch that file, so I suspect it is existing TIMEOUT-flake. cc @nickburris as an FYI, and admin-merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables scroll to text by default for M81. Note we plan to launch via
Finch for M80.
Intent to ship with LGTMs:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ
This patch also updates web platform test expectations:
for the fallback to element anchor behavior.
they need to be updated to test cross-origin navigations. I'll make
this change in a follow-up patch to close bug 1042311.
Bug: 919204
Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838701
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732592}