ripcord: init at 0.4.18 #71066
ripcord: init at 0.4.18 #71066
Conversation
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A desktop chat client for Discord and Slack"; | ||
| homepage = "https://cancel.fm/ripcord/"; |
There was a problem hiding this comment.
Is it really redistributable?
There was a problem hiding this comment.
The author has stated in Discord that it's "all rights reserved but redistribution without modifications is allowed (shareware)"
https://discordapp.com/channels/231664689694638081/231664689694638081/467792133319950337
There was a problem hiding this comment.
| in appimageTools.wrapType2 rec { | ||
| inherit name src; | ||
|
|
||
| extraInstallCommands = '' |
There was a problem hiding this comment.
I think we should wrap the binary to set RIPCORD_ALLOW_UPDATES=0 so it doesn't try to automatically update itself and fail
There was a problem hiding this comment.
afaik ripcord never attempts to self update. Ripcord only queries the update URL to show update notifications in Ripcord itself (which the RIPCORD_ALLOW_UPDATES disables).
There was a problem hiding this comment.
I personally would not like update notifications for software delivered via package manger. You end up in annoying situations where there's a new version released but it's not packaged yet so you get notified over and over.
| @@ -4101,6 +4101,12 @@ | |||
| githubId = 1377571; | |||
| name = "Matthew S. Daiter"; | |||
| }; | |||
| MDeltaX = { | |||
There was a problem hiding this comment.
The addition to maintainer-list.nix should be in a separate commit named maintainers: add MDeltaX
pkgs/applications/networking/instant-messengers/ripcord/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/ripcord/default.nix
Outdated
Show resolved
Hide resolved
…t.nix oh didn't know you could use buttons for this. neat. yeah, just copy pasted some existing appImage expression. can you recommend a linter/beautifier for nix? Co-Authored-By: Alex Rice <alexrice999@hotmail.co.uk>
…t.nix Co-Authored-By: Alex Rice <alexrice999@hotmail.co.uk>
|
will come back to this in the next days |
|
Is this ready for merge? |
|
Hey @MDeltaX, do you think you'll get to this soon, and if not, do you mind if someone else pushes it along? Thanks for doing this work! |
|
Does this need some Qt wrap hooks? I'm not able to run this on Wayland due to the usual Qt platform plugin err. |
|
Christ this is old. Sorry this nobody ever bothered to merge this. My version is more up to date at this point anyway |
|
Then let’s close in favor of the other PR. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @ldesgoui @MP2E @tadeokondrak