[html] Clean state between dialog positioning tests #19657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
domenic
approved these changes
Oct 13, 2019
|
Good point! I'll make that change :) |
Calling `reset()` at the end of every test to close the modal dialog will only be invoked if the test passes. If an expectation fails, the call to `reset()` will never run and the dialog will remain modally open on the page. This causes all further tests to fail because calling `showModal()` on the dialog while it is open is an error. Instead, set up `reset()` to be called as a cleanup after every test regardless of whether the test passes or fails.
dpogue
force-pushed
the
abspos-dialog-layout-reset
branch
from
2e764d2
to
7d237a5
Compare
The `add_cleanup()` calls need to be registered outside of the `assert_throws` block to ensure that the dialogs are actually closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
reset()at the end of every test to close the modal dialog will only be invoked if the test passes. If an expectation fails, the call toreset()will never run and the dialog will remain modally open on the page. This causes all further tests to fail because callingshowModal()on the dialog while it is open is an error.Instead, set up
reset()to be called as a cleanup after every test regardless of whether the test passes or fails.