Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos.tests: silence getfacl absolute path message #70999

Merged
merged 1 commit into from Oct 13, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 11, 2019

Motivation for this change

I noticed several getfacl messages about absolute paths in our tests logs.

Default getfacl behavior is to remove leading slash on absolute
paths in its header printed to stdout.
Before the header it will also print a message about it...

Switches -p -or --absolute-names can turn this off
and remove some noise from our tests logs.


output with noise:

$ getfacl /dev/snd/timer
getfacl: Removing leading '/' from absolute path names
# file: dev/snd/timer
# owner: root
# group: audio
user::rw-
user:demo:rw-
group::rw-
mask::rw-
other::---

-vs- a clean output:

$ getfacl -p /dev/snd/timer
# file: /dev/snd/timer
# owner: root
# group: audio
user::rw-
user:demo:rw-
group::rw-
mask::rw-
other::---
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Default getfacl behavior is to remove leading slash on absolute
paths in its header printed to stdout.
Before the header it will also print a message about it...

Switches -p -or --absolute-names can turn this off
and remove some noise from our tests logs.
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: qt/kde 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Oct 11, 2019
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 12, 2019

@GrahamcOfBorg test gnome3-xorg login

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 13, 2019

@worldofpeace can I ask you for a second look at this? As you maintain pantheon test. :)

@worldofpeace
Copy link
Contributor

@c0bw3b Yep, I did notice this test and it was in my queue to review.
And I also maintain the gnome tests and the xfce4-14 one.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very, very, very harmless 👍

@worldofpeace worldofpeace merged commit 6339c58 into NixOS:master Oct 13, 2019
@c0bw3b c0bw3b deleted the tests/fix/getfacl branch October 13, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: qt/kde 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants