Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

okta-aws: init at 2.0.4 #68816

Closed
wants to merge 1 commit into from
Closed

okta-aws: init at 2.0.4 #68816

wants to merge 1 commit into from
+136 −0

Conversation

arnarg
Copy link
Contributor

@arnarg arnarg commented Sep 14, 2019 •
edited
Loading

Motivation for this change

This is different from aws-okta.
I use this tool for authenticating to AWS with okta.

I'd love to not have the whole jdk11 as a runtime dependency but it doesn't have a jre output. This program requires Java 11.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@arnarg
Copy link
Contributor Author

arnarg commented Sep 14, 2019

This will most likely work on all platforms that support java but I've only tried it on Darwin so I only put that platform. Should this be platforms.all?

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 14, 2019
@arnarg
Copy link
Contributor Author

arnarg commented Oct 10, 2019

I don't want to maintain this anymore

@arnarg arnarg closed this Oct 10, 2019
@arnarg arnarg deleted the add-okta-aws branch October 10, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@arnarg