[LayoutNG] Use legacy borders when painting table cell fragments #19658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1858519
branch
from
6946d84
to
05d3d72
Compare
NG fragments don't support collapsed borders yet. This manifested with background-clip. When the position/size of the clipped background was determined, the cells' full borders were used, not half of the winning border as is correct in collapsed mode. Bug: 1008400 Change-Id: I53a80c88d854136e8d3f540fe7b8c969152aad13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858519 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#705454}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1858519
branch
from
05d3d72
to
6295c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NG fragments don't support collapsed borders yet. This manifested with
background-clip. When the position/size of the clipped background was
determined, the cells' full borders were used, not half of the winning
border as is correct in collapsed mode.
Bug: 1008400
Change-Id: I53a80c88d854136e8d3f540fe7b8c969152aad13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858519
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705454}