Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pwntools: init at unstable-2019-10-09 #70982

Closed
wants to merge 1 commit into from
Closed

python3Packages.pwntools: init at unstable-2019-10-09 #70982

wants to merge 1 commit into from
+55 −20

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

pwntools now works with Python3!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bennofs @kristoff3r

Sorry, something went wrong.

@Pamplemousse Pamplemousse requested a review from FRidh as a code owner October 11, 2019 16:44
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package labels Oct 11, 2019
@ofborg ofborg bot requested review from kristoff3r and bennofs October 11, 2019 16:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 11, 2019
jonringer
jonringer reviewed Oct 11, 2019
View reviewed changes
@Pamplemousse Pamplemousse changed the title python3Packages.pwntools: init at dev3 python3Packages.pwntools: init at unstable-2019-10-09 Oct 11, 2019
@Pamplemousse
Copy link
Member Author

Irrelevant since #72879 .

@jonringer
Copy link
Contributor

jonringer commented Nov 13, 2019 •
edited
Loading

sorry for letting this slide for so long, 19.09 and python3.8 release caused a lot of churn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

@kristoff3r kristoff3r

@bennofs bennofs

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pamplemousse @jonringer @kristoff3r @FRidh