Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart Safari after timeout/error #19620

Closed
gsnedders opened this issue Oct 10, 2019 · 4 comments · Fixed by #27427
Closed

Restart Safari after timeout/error #19620

gsnedders opened this issue Oct 10, 2019 · 4 comments · Fixed by #27427
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run
Projects
Reliable Safari results

Comments

@gsnedders
Copy link
Member

At the moment we fail to even send delete session if the HTTP client has hung because httplib fails to send it because it's already waiting on a response. We should do better.
@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run labels Oct 10, 2019
@gsnedders gsnedders added this to To do in Reliable Safari results via automation Oct 10, 2019
@foolip
Copy link
Member

foolip commented Oct 14, 2019

This should resolve #18634 and #18635.

@foolip foolip closed this as completed Nov 21, 2019
Reliable Safari results automation moved this from To do to Done Nov 21, 2019
@foolip foolip reopened this Nov 21, 2019
Reliable Safari results automation moved this from Done to To do Nov 21, 2019
@foolip
Copy link
Member

foolip commented Dec 20, 2019

This might have avoided #20878, where we failed after "CRITICAL Max restarts exceeded".

@foolip
Copy link
Member

foolip commented Dec 20, 2019

Yep, #20878 (comment) looks like this issue, "Could not create a session: The Safari instance is already paired with another WebDriver session."

@foolip foolip mentioned this issue Dec 20, 2019
Merged
@gsnedders
Copy link
Member Author

Likely would also resolve #18995.

@gsnedders gsnedders removed their assignment Jan 31, 2020
@web-platform-tests web-platform-tests deleted a comment Mar 15, 2020
@foolip foolip mentioned this issue May 15, 2020
Closed
This was referenced May 25, 2020
Closed
Closed
@gsnedders gsnedders mentioned this issue Jan 29, 2021
Closed
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Feb 1, 2021
@gsnedders
Fix web-platform-tests#19620: add an option to wptrunner to stop Safari
4daded6 
Given Safari runs as a singleton process, and the user may have other
things open in the browser, this doesn't make Safari get stopped by
default (i.e., the status quo of only restarting safaridriver is
maintained); however it does add a --kill-safari option, and makes use
of this on Azure Pipelines.
@gsnedders gsnedders mentioned this issue Feb 1, 2021
Merged
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Feb 4, 2021
@gsnedders
Fix web-platform-tests#19620: add an option to wptrunner to stop Safari
f2fa201 
Given Safari runs as a singleton process, and the user may have other
things open in the browser, this doesn't make Safari get stopped by
default (i.e., the status quo of only restarting safaridriver is
maintained); however it does add a --kill-safari option, and makes use
of this on Azure Pipelines.
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Feb 4, 2021
@gsnedders
fixup! Fix web-platform-tests#19620: add an option to wptrunner to st…
92c8536 
…op Safari
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Feb 4, 2021
@gsnedders
fixup! Fix web-platform-tests#19620: add an option to wptrunner to st…
771f7a6 
…op Safari
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Feb 4, 2021
@gsnedders
fixup! Fix web-platform-tests#19620: add an option to wptrunner to st…
0d8a122 
…op Safari
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Feb 4, 2021
@gsnedders
fixup! Fix web-platform-tests#19620: add an option to wptrunner to st…
143e6a2 
…op Safari
Reliable Safari results automation moved this from To do to Done Feb 4, 2021
gsnedders added a commit that referenced this issue Feb 4, 2021
@gsnedders
Fix #19620: add an option to wptrunner to stop Safari
bd7587b 
Given Safari runs as a singleton process, and the user may have other
things open in the browser, this doesn't make Safari get stopped by
default (i.e., the status quo of only restarting safaridriver is
maintained); however it does add a --kill-safari option, and makes use
of this on Azure Pipelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run
Projects
Reliable Safari results
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #19620: add an option to wptrunner to stop Safari gsnedders/web-platform-tests
3 participants
@stephenmcgruer @gsnedders @foolip