Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamlit: init at 0.49.0 #70909

Merged
merged 1 commit into from
Nov 6, 2019
Merged

streamlit: init at 0.49.0 #70909

merged 1 commit into from
Nov 6, 2019
+36 −0

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Oct 10, 2019 •
edited
Loading

Motivation for this change

Not present in Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 10, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 10, 2019

@GrahamcOfBorg eval

jonringer
jonringer reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get rid of streamlit.cmd as it's largely useless

[nix-shell:/home/jon/.cache/nix-review/pr-70909]$ cat ./results/streamlit/bin/streamlit.cmd
@echo OFF
python -m streamlit %*

  postInstall = ''
    rm $out/bin/streamlit.cmd # remove windows helper
  '';

@yrashk
Copy link
Contributor Author

yrashk commented Oct 11, 2019

@jonringer totally makes sense. Updated the PR.

@yrashk
Copy link
Contributor Author

yrashk commented Oct 14, 2019

@jonringer Anything else worth updating?

jonringer
jonringer reviewed Oct 14, 2019
View reviewed changes
@yrashk
Copy link
Contributor Author

yrashk commented Oct 14, 2019

@jonringer I updated the PR. Can you take a look? I think I've addressed your concerns.

@yrashk
Copy link
Contributor Author

yrashk commented Oct 22, 2019

@jonringer anything else worth updating before merging?

jonringer
jonringer approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[3 built, 50 copied (71.2 MiB), 8.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70909
1 package were build:
streamlit

would like some tests, but they look more integration oriented, and probably not suitable for a sandbox env

@yrashk
Copy link
Contributor Author

yrashk commented Nov 4, 2019

@jonringer apologies for the delay, I've applied your suggestions and also bumped up the version to 0.49.0

@yrashk yrashk changed the title streamlit: init at 0.47.4 streamlit: init at 0.49.0 Nov 4, 2019
@yrashk
Copy link
Contributor Author

yrashk commented Nov 6, 2019

@jonringer I updated the PR as per your latest suggestion.

jonringer
jonringer approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[3 built, 6 copied (6.8 MiB), 0.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70909
1 package were build:
streamlit

thank you for dealing with all the comments! :)

@jonringer jonringer merged commit 2e52f98 into NixOS:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yrashk @c0bw3b @jonringer