Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonobuoy: 0.15.0 -> 0.16.1 #70904

Merged
merged 1 commit into from Nov 22, 2019
Merged

sonobuoy: 0.15.0 -> 0.16.1 #70904

merged 1 commit into from Nov 22, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 10, 2019 •
edited

Motivation for this change

Update sonobuoy to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@saschagrunert
Copy link
Member Author

cc @carlosdagos

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build sonobuoy

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 11, 2019

@GrahamcOfBorg eval

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 21, 2019

Some context about the change of repo:
https://sonobuoy.io/new-github-org/

c0bw3b
c0bw3b requested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should read 0.15.0 -> 0.16.1 and not 1.15.0 -> 1.16.1
+ upstream is now at 0.16.4

pkgs/applications/networking/cluster/sonobuoy/default.nix Outdated Show resolved Hide resolved
@saschagrunert
sonobuoy: 0.15.0 -> 0.16.1
c1d22b4 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title sonobuoy: 1.15.0 -> 1.16.1 sonobuoy: 0.15.0 -> 0.16.1 Nov 22, 2019
@saschagrunert
Copy link
Member Author

Commit message should read 0.15.0 -> 0.16.1 and not 1.15.0 -> 1.16.1

  • upstream is now at 0.16.4

Ah yes, fixed that as well :) Thanks for the review

@ofborg ofborg bot requested review from carlosdagos and ehmry November 22, 2019 19:21
@c0bw3b c0bw3b merged commit 801da15 into NixOS:master Nov 22, 2019
@saschagrunert saschagrunert deleted the sonobuoy branch November 22, 2019 21:29
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@saschagrunert @dtzWill
sonobuoy: 0.15.0 -> 0.16.1 (NixOS#70904)
3b92ee7 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
(cherry picked from commit 801da15)
@wilsonehusin wilsonehusin mentioned this pull request Oct 15, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@carlosdagos carlosdagos Awaiting requested review from carlosdagos

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @c0bw3b