Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-ethereum: 1.9.5 -> 1.9.6 #70908

Merged
merged 1 commit into from
Oct 12, 2019
Merged

go-ethereum: 1.9.5 -> 1.9.6 #70908

merged 1 commit into from
Oct 12, 2019
+2 −2

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Oct 10, 2019

Motivation for this change

Update go-ethereum to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis @asymmetric @lionello

Sorry, something went wrong.

@adisbladis
Copy link
Member

@GrahamcOfBorg build go-ethereum

@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 11, 2019

@GrahamcOfBorg eval

@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 12, 2019

@adisbladis Thanks for the review. Could we merge this PR?

@asymmetric
Copy link
Contributor

Builds and binary seems to work on NixOS 19.09.

@adisbladis adisbladis merged commit e9aa14c into NixOS:master Oct 12, 2019
@xrelkd xrelkd deleted the update/go-ethereum branch October 12, 2019 16:47
@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 12, 2019

@adisbladis @asymmetric Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @adisbladis @asymmetric