Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geekbench 4.4.1 => 5.0.2 #71050

Merged
merged 1 commit into from Oct 13, 2019
Merged

geekbench 4.4.1 => 5.0.2 #71050

merged 1 commit into from Oct 13, 2019

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented Oct 12, 2019 •
edited

Motivation for this change

Update geekbench to newest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from michalrus October 12, 2019 19:25
c0bw3b
c0bw3b approved these changes Oct 13, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 13, 2019

cc @michalrus

@c0bw3b c0bw3b merged commit 555392b into NixOS:master Oct 13, 2019
@cyplo cyplo deleted the geekbench5 branch October 13, 2019 20:56
@cyplo cyplo restored the geekbench5 branch November 14, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@michalrus michalrus Awaiting requested review from michalrus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyplo @c0bw3b