ocamlPackages.bigstringaf: 0.3.0 → 0.6.0 #70955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build ocamlPackages.httpaf |
jonringer
reviewed
Oct 11, 2019
| @@ -13,9 +13,9 @@ buildDunePackage rec { | |||
| sha256 = "0z6ikwlqad91iac0q5z88p3wzq5k15y86ckzmhdq1aqwrcm14bq2"; | |||
| }; | |||
|
|
|||
| buildInputs = [ alcotest ]; | |||
| buildInputs = lib.optional doCheck alcotest; | |||
There was a problem hiding this comment.
shouldn't this be part of checkInputs?
| @@ -11,14 +11,14 @@ buildDunePackage rec { | |||
| sha256 = "0i2r004ihj00hd97475y8nhjqjln58xx087zcjl0dfp0n7q80517"; | |||
| }; | |||
|
|
|||
| buildInputs = [ alcotest ]; | |||
| buildInputs = lib.optional doCheck alcotest; | |||
There was a problem hiding this comment.
put into checkInputs? also avoids having alcotest in the closure.
There was a problem hiding this comment.
buildInputs usually are meant to be used at runtime, if a store path gets added somehow during the build, then the package closure will include it.
There was a problem hiding this comment.
I don’t think so: build inputs are primarily used at build time.
The package closure is computed from its contents: the details of the source of the derivation are irrelevant (if they don’t change the build results).
vbgl
force-pushed
the
ocaml-bigstringaf-0.6.0
branch
from
ded594a
to
0eaca4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The updated version is a dependency of ocaml-git ≥ 2.1
Tests of faraday fail with:
The error only shows up with OCaml 4.07; I’ve thus disabled them for that version. The situation of httpaf is similar.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)