Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] chromium: 77.0.3865.90 -> 77.0.3865.120 #70957

Closed
wants to merge 1 commit into from
Closed

[19.09] chromium: 77.0.3865.90 -> 77.0.3865.120 #70957

wants to merge 1 commit into from
+29 −39

Conversation

ivan
Copy link
Member

@ivan ivan commented Oct 11, 2019 •
edited
Loading

Motivation for this change

Backport #70943

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested stable: YouTube, audio output, WebGL OK, Widevine OK
Tested beta: YouTube, audio output, WebGL OK, Widevine NOT OK, needs fixed patch for changes in 78+ @jflanglois
Tested dev: YouTube, audio output, WebGL OK, Widevine NOT OK, needs fixed patch for changes in 78+

I don't want this held up for a Widevine fix in {beta, dev}, the security fixes are much more important.

Notify maintainers

cc @bendlas

Sorry, something went wrong.

@ivan
chromium: 77.0.3865.90 -> 77.0.3865.120
cf2f517 
CVE-2019-13693 CVE-2019-13694 CVE-2019-13695 CVE-2019-13696
CVE-2019-13697

Disable jumbo mode because upstream dropped support for it.
(See chromium-dev "We're removing support for the jumbo build")

This makes builds take about 3x as long, but we have no alternative.

(cherry picked from commit 371005c2610af880781f4d70e19747a63768c88e)
@ofborg ofborg bot requested a review from bendlas October 11, 2019 07:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 11, 2019
@bendlas
Copy link
Contributor

bendlas commented Oct 11, 2019

d548264

@bendlas bendlas closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendlas bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @bendlas