Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wacomtablet kcm #68836

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Wacomtablet kcm #68836

merged 3 commits into from
Oct 11, 2019
+40 −1

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Sep 15, 2019

Motivation for this change

Add new package for KDE Wacom Tablet Configuration GUI and optionally include it in the plasma5 package set if services.xserver.wacom.enable is true.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers (of related packages)

cc @ttuegel
cc @abbradar
cc @cillianderoiste

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 15, 2019
tilpner
tilpner reviewed Sep 15, 2019
View reviewed changes
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 15, 2019
@tilpner
Copy link
Member

tilpner commented Sep 15, 2019

@GrahamcOfBorg build wacomtablet-kcm

@Thra11
wacomtablet: init at 3.2.0
0d75367
@Thra11
nixos/plasma5: optionally include wacomtablet
3f52518 
When services.xserver.wacom.enable is true, include the KDE configuration
GUI for Wacom Tablets in the Plasma5 desktop.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/61

@aanderse
Copy link
Member

If you can't find someone to test let me know and I'll dig my tablet out.

@Thra11
Copy link
Member Author

Thra11 commented Oct 10, 2019

@aanderse If you have time, that would be most appreciated.

aanderse
aanderse approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing steps taken:

  • paste contents of pkgs/tools/misc/wacomtablet/default.nix from this PR into ~/wacom.nix
  • add (pkgs.libsForQt5.callPackage /home/aaron/wacom.nix { }) to environment.systemPackages in configuration.nix
  • add services.xserver.wacom.enable = true; to configuration.nix
  • type sudo nixos-rebuild test
  • restart x
  • observe working settings manager as well as wacom tablet

@aanderse
Copy link
Member

I didn't look into it... but what is with the "No attempt" and error from the bot?

@tilpner
Copy link
Member

tilpner commented Oct 11, 2019 •
edited
Loading

@GrahamcOfBorg build wacomtablet

(The attribute name was changed from wacomtablet-kcm to just wacomtablet)

@aanderse aanderse merged commit 0b6067f into NixOS:master Oct 11, 2019
@Thra11 Thra11 deleted the wacomtablet-kcm branch October 11, 2019 14:38
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 16, 2020
@aanderse @dtzWill
Merge pull request NixOS#68836 from Thra11/wacomtablet-kcm

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
c770f6e 
wacomtablet: init at 3.2.0
(cherry picked from commit 0b6067f)
@deliciouslytyped deliciouslytyped mentioned this pull request Nov 25, 2023
Closed
@K900 K900 mentioned this pull request Mar 1, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilpner tilpner

@aanderse aanderse

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Thra11 @tilpner @nixos-discourse @aanderse