Wacomtablet kcm #68836
Merged
Wacomtablet kcm #68836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilpner
reviewed
Sep 15, 2019
tilpner
reviewed
Sep 15, 2019
tilpner
reviewed
Sep 15, 2019
|
@GrahamcOfBorg build wacomtablet-kcm |
When services.xserver.wacom.enable is true, include the KDE configuration GUI for Wacom Tablets in the Plasma5 desktop.
Thra11
force-pushed
the
wacomtablet-kcm
branch
from
4df99a1
to
3f52518
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/61 |
|
If you can't find someone to test let me know and I'll dig my tablet out. |
|
@aanderse If you have time, that would be most appreciated. |
aanderse
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Testing steps taken:
- paste contents of
pkgs/tools/misc/wacomtablet/default.nixfrom this PR into~/wacom.nix - add
(pkgs.libsForQt5.callPackage /home/aaron/wacom.nix { })toenvironment.systemPackagesinconfiguration.nix - add
services.xserver.wacom.enable = true;toconfiguration.nix - type
sudo nixos-rebuild test - restart x
- observe working settings manager as well as wacom tablet
|
I didn't look into it... but what is with the "No attempt" and error from the bot? |
|
@GrahamcOfBorg build wacomtablet (The attribute name was changed from wacomtablet-kcm to just wacomtablet) |
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 16, 2020
wacomtablet: init at 3.2.0 (cherry picked from commit 0b6067f)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add new package for KDE Wacom Tablet Configuration GUI and optionally include it in the plasma5 package set if
services.xserver.wacom.enableis true.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers (of related packages)
cc @ttuegel
cc @abbradar
cc @cillianderoiste