Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-edit: 0.3.3 -> 0.4.0 #70917

Closed
wants to merge 1 commit into from
Closed

cargo-edit: 0.3.3 -> 0.4.0 #70917

wants to merge 1 commit into from

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented Oct 10, 2019

Motivation for this change

I'm trying to update cargo-edit to the latest version, however the tests do not compile. I cloned the repo locally and ran the tests from there with cargo test, which worked fine. I get a ton of errors in nixpkgs when I try to build it. See the log below. cc @killercup, do you have any idea what gives?

failures:

---- adds_dependency stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

---- adds_dependency_with_custom_target stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency_with_custom_target' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- add_prints_message_for_dev_deps stdout ----
thread 'add_prints_message_for_dev_deps' panicked at 'Assertion failed for `target/debug/cargo-add add docopt --dev --vers 0.8.0 --manifest-path=/build/cargo-edit-test.oxN6yZ6fUOQ9/Cargo.toml`
with: Unexpected return status: failure
stdout=``````
stderr=```Command failed due to unhandled error: Invalid cargo config

```', /build/cargo-edit-v0.4.0-vendor/assert_cli/src/assert.rs:441:13

---- add_prints_message_with_section stdout ----
thread 'add_prints_message_with_section' panicked at 'Assertion failed for `target/debug/cargo-add add clap --optional --target=mytarget --vers=0.1.0 --manifest-path=/build/cargo-edit-test.YIy1Ievk9IUs/Cargo.toml`
with: Unexpected return status: failure
stdout=``````
stderr=```Command failed due to unhandled error: Invalid cargo config

```', /build/cargo-edit-v0.4.0-vendor/assert_cli/src/assert.rs:441:13

---- add_prints_message stdout ----
thread 'add_prints_message' panicked at 'Assertion failed for `target/debug/cargo-add add docopt --vers=0.6.0 --manifest-path=/build/cargo-edit-test.HuoKC47NWz2z/Cargo.toml`
with: Unexpected return status: failure
stdout=``````
stderr=```Command failed due to unhandled error: Invalid cargo config

```', /build/cargo-edit-v0.4.0-vendor/assert_cli/src/assert.rs:441:13

---- adds_dependency_with_upgrade_none stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency_with_upgrade_none' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_dependency_with_upgrade_minor stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency_with_upgrade_minor' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_dependency_with_upgrade_all stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency_with_upgrade_all' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- add_prints_message_for_build_deps stdout ----
thread 'add_prints_message_for_build_deps' panicked at 'Assertion failed for `target/debug/cargo-add add hello-world --build --vers 0.1.0 --manifest-path=/build/cargo-edit-test.CvSmu7adtrwU/Cargo.toml`
with: Unexpected return status: failure
stdout=``````
stderr=```Command failed due to unhandled error: Invalid cargo config

```', /build/cargo-edit-v0.4.0-vendor/assert_cli/src/assert.rs:441:13

---- adds_dependency_with_target_triple stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency_with_target_triple' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_dependency_with_upgrade_patch stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency_with_upgrade_patch' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_local_source_using_flag stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_local_source_using_flag' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_dependency_with_target_cfg stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dependency_with_target_cfg' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_dev_build_dependency stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_dev_build_dependency' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_git_source_using_flag stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_git_source_using_flag' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_local_source_without_flag stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_local_source_without_flag' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_local_source_with_version_flag_and_semver_metadata stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_local_source_with_version_flag_and_semver_metadata' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_multiple_dependencies stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_multiple_dependencies' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_local_source_with_inline_version_notation stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_local_source_with_inline_version_notation' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_multiple_dependencies_with_some_versions stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_multiple_dependencies_with_some_versions' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_multiple_dependencies_with_versions stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_multiple_dependencies_with_versions' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_local_source_with_version_flag stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_local_source_with_version_flag' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_multiple_dev_build_dependencies stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_multiple_dev_build_dependencies' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_multiple_no_default_features_dependencies stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_multiple_no_default_features_dependencies' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_specified_version stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_specified_version' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_prerelease_dependency stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_prerelease_dependency' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_optional_dependency stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_optional_dependency' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_no_default_features_dependency stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_no_default_features_dependency' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_multiple_optional_dependencies stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_multiple_optional_dependencies' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_specified_version_with_inline_notation stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_specified_version_with_inline_notation' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- adds_sorted_dependencies stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'adds_sorted_dependencies' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- overwrite_version_with_path stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'overwrite_version_with_path' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- overwrite_git_with_path stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'overwrite_git_with_path' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- overwrite_version_with_git stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'overwrite_version_with_git' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- overwrite_path_with_version stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'overwrite_path_with_version' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9

---- overwrite_version_with_version stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT:
STDERR: Command failed due to unhandled error: Invalid cargo config


thread 'overwrite_version_with_version' panicked at 'cargo-add failed to execute', tests/utils.rs:65:9


failures:
    add_prints_message
    add_prints_message_for_build_deps
    add_prints_message_for_dev_deps
    add_prints_message_with_section
    adds_dependency
    adds_dependency_with_custom_target
    adds_dependency_with_target_cfg
    adds_dependency_with_target_triple
    adds_dependency_with_upgrade_all
    adds_dependency_with_upgrade_minor
    adds_dependency_with_upgrade_none
    adds_dependency_with_upgrade_patch
    adds_dev_build_dependency
    adds_git_source_using_flag
    adds_local_source_using_flag
    adds_local_source_with_inline_version_notation
    adds_local_source_with_version_flag
    adds_local_source_with_version_flag_and_semver_metadata
    adds_local_source_without_flag
    adds_multiple_dependencies
    adds_multiple_dependencies_with_some_versions
    adds_multiple_dependencies_with_versions
    adds_multiple_dev_build_dependencies
    adds_multiple_no_default_features_dependencies
    adds_multiple_optional_dependencies
    adds_no_default_features_dependency
    adds_optional_dependency
    adds_prerelease_dependency
    adds_sorted_dependencies
    adds_specified_version
    adds_specified_version_with_inline_notation
    overwrite_git_with_path
    overwrite_path_with_version
    overwrite_version_with_git
    overwrite_version_with_path
    overwrite_version_with_version

test result: FAILED. 11 passed; 36 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test cargo-add'
builder for '/nix/store/0mchn429s5pxhj4g6j0i905rwjc0zqsb-cargo-edit-v0.4.0.drv' failed with exit code 101
error: build of '/nix/store/0mchn429s5pxhj4g6j0i905rwjc0zqsb-cargo-edit-v0.4.0.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Gerschtli @jb55

@ofborg ofborg bot requested review from Gerschtli and jb55 October 10, 2019 15:31
@killercup
Copy link
Member

Hm, not sure what this is, but I'll try to have a look at it over the weekend.

@Gerschtli
Copy link
Contributor

I tried to do this update some weeks ago, but couldn't figure it out either..

@kira-bruneau
Copy link
Contributor

All tests pass under nix-shell running cargo test without dependency vendoring. If I vendor the dependencies manually before running cargo test, I get the following error:

failures:

---- upgrade_to_lockfile stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT: 
STDERR: Command failed due to unhandled error: Invalid manifest

Caused by: Error during execution of `cargo metadata`: error: failed to select a version for the requirement `rand = "= 0.3.10"`
  candidate versions found which didn't match: 0.7.2, 0.6.5, 0.4.6
  location searched: directory source `/tmp/nix/cargo-edit/source/vendor` (which is replacing registry `https://github.com/rust-lang/c
rates.io-index`)                                                                                                                     
required by package `one v0.1.0 (/run/user/1000/cargo-edit-test.CN8wwS6TWgym)`
perhaps a crate was updated and forgotten to be re-vendored?


thread 'upgrade_to_lockfile' panicked at 'cargo-upgrade failed to execute', tests/utils.rs:75:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

---- upgrade_workspace_to_lockfile stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT: 
STDERR: Command failed due to unhandled error: Invalid manifest

Caused by: Error during execution of `cargo metadata`:     Blocking waiting for file lock on package cache
error: failed to select a version for the requirement `libc = "= 0.2.62"`
  candidate versions found which didn't match: 0.2.65
  location searched: directory source `/tmp/nix/cargo-edit/source/vendor` (which is replacing registry `https://github.com/rust-lang/c
rates.io-index`)                                                                                                                     
required by package `one v0.1.0 (/run/user/1000/upgrade_workspace.DcB2AlB5J7Gc/one)`
perhaps a crate was updated and forgotten to be re-vendored?


thread 'upgrade_workspace_to_lockfile' panicked at 'cargo-upgrade failed to execute', tests/utils.rs:75:9


failures:
    upgrade_to_lockfile
    upgrade_workspace_to_lockfile

It's different to the error given by nix-build, but maybe it's related?

@oxalica oxalica mentioned this pull request Dec 4, 2019
Merged
10 tasks
@sondr3
Copy link
Contributor Author

sondr3 commented Dec 4, 2019

This PR has been superceded by #74981, so I'll close this.

@sondr3 sondr3 closed this Dec 4, 2019
@sondr3 sondr3 deleted the cargo-edit/0.4.0 branch December 4, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sondr3 @killercup @Gerschtli @kira-bruneau