Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdf2psf: fix /usr/share -> /share, and don't install env-vars #68747

Merged
merged 2 commits into from Oct 12, 2019
Merged

bdf2psf: fix /usr/share -> /share, and don't install env-vars #68747

merged 2 commits into from Oct 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 14, 2019

Motivation for this change

(instead install what we want directly)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dtzWill
bdf2psf: fix /usr/share -> /share, and don't install env-vars
c99f686 
(instead install what we want directly)
@ofborg ofborg bot requested review from vrthra and rnhmjoj September 14, 2019 04:02
rnhmjoj
rnhmjoj requested changes Sep 14, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks gohufont, could you cherry-pick this rnhmjoj@355024f?

@chkno
Copy link
Member

chkno commented Oct 3, 2019

With rnhmjoj's suggested change, this looks good to me.

This change fixes the man page too. Before:

$ man bdf2psf
No manual entry for bdf2psf

After:

$ man bdf2psf
NAME
       bdf2psf - convert a BDF font to PSF format for the Linux console
...

Thanks!

@dtzWill
Copy link
Member Author

dtzWill commented Oct 7, 2019

Pushed with mentioned commit applied, look good?

@ofborg ofborg bot requested a review from rnhmjoj October 7, 2019 23:32
c0bw3b
c0bw3b approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review is good and bdf2psf works

@c0bw3b c0bw3b merged commit 98b7447 into NixOS:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkno chkno chkno approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @chkno @rnhmjoj @c0bw3b