Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler_0_61: add patch for CVE-2019-9959 #71042

Merged
merged 2 commits into from
Oct 13, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 12, 2019

Motivation for this change

We still have an older 0.61 release of poppler in the tree (poppler_0_61). This should fix CVE-2019-9959 for it.

https://nvd.nist.gov/vuln/detail/CVE-2019-9959

Added a custom patch because while the upstream fix does apply as a patch, it doesn't take into account the openjpeg1/openjpeg2 split 0.61 still has (simply requiring a duplicated section).

While I was here I also bumped it from 0.61.0 -> 0.61.1.

For the main poppler package, we should be looking at merging #60701.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
dadada Tim Schubert
custom adapted patch to accommodate the openjpeg1/openjpeg2 split that
0.61 still has

Verified

This commit was signed with the committer’s verified signature.
dadada Tim Schubert
@ofborg ofborg bot requested a review from ttuegel October 12, 2019 17:08
@veprbl veprbl added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 13, 2019
@ttuegel ttuegel merged commit 08ff114 into NixOS:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants