Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs-uae: 2.8.4 -> 3.0.0 #71041

Merged
merged 1 commit into from Oct 16, 2019
Merged

fs-uae: 2.8.4 -> 3.0.0 #71041

merged 1 commit into from Oct 16, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Oct 12, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from AndersonTorres October 12, 2019 16:47
@mmahut
Copy link
Member

mmahut commented Oct 16, 2019

@GrahamcOfBorg build fs-uae

mmahut added a commit that referenced this pull request Oct 16, 2019
@mmahut
Merge pull request #71041 from nyanloutre/fs_uae_3_0_0
b02ae8e 
fs-uae: 2.8.4 -> 3.0.0
@mmahut mmahut merged commit b02ae8e into NixOS:master Oct 16, 2019
@mmahut mmahut merged commit 75f52e1 into NixOS:master Oct 16, 2019
@nyanloutre nyanloutre deleted the fs_uae_3_0_0 branch October 16, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @mmahut