Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utsushi: 3.57.0 -> 3.59.2 #71018

Merged
merged 1 commit into from Oct 14, 2019
Merged

utsushi: 3.57.0 -> 3.59.2 #71018

merged 1 commit into from Oct 14, 2019

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Oct 12, 2019

  • building from gitlab source
  • reorderd dependencies to be in logical/alphabetical order
  • replaced patches with substituteInPlace, as patches broke the installChecks
    and substituteInPlace may be more robust than making new patches for each
    release. Also the compiled source is now closer to upstream than
    before.
  • added installChecks
  • added all supported devices as listed on epson.net

(cherry picked from commit 9eb00ac)

Reference: #70160 (comment)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @grahamc
Please try to build with @GrahamcOfBorg . I did not test this build for a lack of time.

@grahamc
Copy link
Member

grahamc commented Oct 12, 2019

@GrahamcOfBorg build utsushi

@grahamc grahamc changed the base branch from staging-19.09 to release-19.09 October 12, 2019 13:57
@grahamc grahamc changed the base branch from release-19.09 to staging-19.09 October 12, 2019 13:57
@ofborg ofborg bot requested a review from edolstra October 12, 2019 14:12
@wucke13
Copy link
Contributor Author

wucke13 commented Oct 13, 2019

@grahamc what's going on with the branches here?

@grahamc
Copy link
Member

grahamc commented Oct 13, 2019

Please cherry-pick to the release-19.09 branch, and then send the PR against release-19.09. staging-19.09 is only for really big changes.

@wucke13 wucke13 changed the base branch from staging-19.09 to release-19.09 October 13, 2019 23:07
@wucke13
utsushi: 3.57.0 -> 3.59.2
2be9a0d 
+ building from gitlab source
+ reorderd dependencies to be in logical/alphabetical order
+ replaced patches with substituteInPlace, as patches broke the installChecks
  and substituteInPlace may be more robust than making new patches for each
  release. Also the compiled source is now closer to upstream than
  before.
+ added installChecks
+ added all supported devices as listed on epson.net

(cherry picked from commit 9eb00ac)
@wucke13
Copy link
Contributor Author

wucke13 commented Oct 13, 2019

@grahamc done.

@grahamc
Copy link
Member

grahamc commented Oct 14, 2019

@ofborg build utsushi

@grahamc grahamc merged commit fac69b3 into NixOS:release-19.09 Oct 14, 2019
@wucke13 wucke13 deleted the staging-19.09 branch October 15, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wucke13 @grahamc