Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eksctl: 0.6.0 -> 0.7.0 #71014

Merged
merged 1 commit into from Oct 26, 2019
Merged

eksctl: 0.6.0 -> 0.7.0 #71014

merged 1 commit into from Oct 26, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Oct 12, 2019

Motivation for this change

Update eksctl to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit October 12, 2019 03:36
@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 26, 2019

@GrahamcOfBorg build eksctl

@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 26, 2019

Hi, @marsam, thanks for contributing the PR #71049!
Could you review this PR? Thank you very much!

@marsam marsam merged commit 5fd5403 into NixOS:master Oct 26, 2019
@marsam
Copy link
Contributor

marsam commented Oct 26, 2019

Sorry about the delay. LGTM, thank you!

@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 26, 2019

@marsam Thank you very much!

@xrelkd xrelkd deleted the update/eksctl branch October 26, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @marsam