Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoptopenjdk-bin: add OpenJDK 13 #71016

Closed
wants to merge 2 commits into from

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Adds AdoptOpenJDK builds of OpenJDK 13, as well as updating some of the other builds. AdoptOpenJDK provides 32-bit ARM builds of OpenJDK 8 now, so the update script added them as well. I tested that JDK 13 build was able to start JMeter on x86_64-linux, and that the armv7l-linux JDK 8 package builds, but did not do any runtime testing on that platform.

I do not think the 32-bit ARM JDK 8 build will be able to bootstrap our openjdk8 package (but I haven't tried), because I believe OpenJDK 8 requires some patches to build on ARM.

The JDK 13 builds should be able to bootstrap our source build of OpenJDK 13 in #70983.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jerith666
cc @taku0

Sorry, something went wrong.

@lopsided98 lopsided98 mentioned this pull request Oct 12, 2019
10 tasks
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 12, 2019
@ofborg ofborg bot requested a review from taku0 October 12, 2019 03:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 12, 2019
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It works on nixOS and macOS Catalina (10.15).

@ofborg ofborg bot requested a review from taku0 December 5, 2019 18:32
@taku0
Copy link
Contributor

taku0 commented Dec 7, 2019

LGTM again. It works on nixOS and macOS Catalina (10.15). Not tested on ARM processors.

@lopsided98
Copy link
Contributor Author

Included in #70983

@lopsided98 lopsided98 closed this Mar 22, 2020
@lopsided98 lopsided98 deleted the adoptopenjdk-13 branch March 22, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants