Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasty-tap: fix tests #71017

Merged
merged 1 commit into from
Oct 14, 2019
Merged

tasty-tap: fix tests #71017

merged 1 commit into from
Oct 14, 2019
+7 −1

Conversation

sevanspowell
Copy link
Contributor

Motivation for this change
  • Broken tasty-tap derivation due to failing tests.
  • The golden test for tasty-tap is out-of-date with the current TAP format.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti @basvandijk

Sorry, something went wrong.

peti
peti requested changes Oct 13, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove tasty-tap from the broken-packages section in configuration-hackage2nix.yaml, too. https://www.youtube.com/watch?v=KLhkAEk8I20 might be interesting to watch in that regard.

@peti peti force-pushed the haskell-updates branch 2 times, most recently from 407ecc3 to 33366cc Compare October 13, 2019 12:27
@ofborg ofborg bot added 6.topic: haskell 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 13, 2019
@sevanspowell sevanspowell force-pushed the feature/fix-tasty-tap-tests branch 2 times, most recently from dfa9ad6 to 510f0e1 Compare October 13, 2019 23:15
@sevanspowell
tasty-tap: fix tests

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
GPG key ID: 9F6A681E35EF8B56
Verified
Learn about vigilant mode
1e40b69 
- The golden test for tasty-tap is out-of-date with the current TAP
  format. An issue has been submitted upstream here:
  MichaelXavier/tasty-tap#2.
- I've created a pull request that makes the (minor) changes to the
  golden test file and applied the patch for that pull request here.
- Remove tasty-tap from broken-packages
@sevanspowell sevanspowell force-pushed the feature/fix-tasty-tap-tests branch from 510f0e1 to 1e40b69 Compare October 13, 2019 23:21
@sevanspowell
Copy link
Contributor Author

Sorry @peti, I watched that video but didn't pay enough attention.

Done.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 13, 2019
@peti peti merged commit 5f2f944 into NixOS:haskell-updates Oct 14, 2019
sevanspowell added a commit to sevanspowell/nixpkgs that referenced this pull request Mar 19, 2020
@sevanspowell
tasty-tap: fix failing build

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
GPG key ID: 9F6A681E35EF8B56
Verified
Learn about vigilant mode
126c491 
- tasty-tap's tests were failing. In
  NixOS#71017 a patch generated from a
  PR was applied to fix this.
- That PR has now been merged into tasty-tap and was released with
  version 0.1.0.
- tasty-tap is now at version 0.1.0 in nixpkgs and so the patch fails
  to apply, breaking the build.
- Removed the patch and removed tasty-tap from list of broken
  packages.
@sevanspowell sevanspowell mentioned this pull request Mar 19, 2020
Merged
10 tasks
peti pushed a commit that referenced this pull request Mar 20, 2020
@sevanspowell @peti
tasty-tap: fix failing build

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
GPG key ID: 9F6A681E35EF8B56
Verified
Learn about vigilant mode
11bc4ee 
- tasty-tap's tests were failing. In
  #71017 a patch generated from a
  PR was applied to fix this.
- That PR has now been merged into tasty-tap and was released with
  version 0.1.0.
- tasty-tap is now at version 0.1.0 in nixpkgs and so the patch fails
  to apply, breaking the build.
- Removed the patch and removed tasty-tap from list of broken
  packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

@basvandijk basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sevanspowell @peti