Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0a18e8f311a6
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3fc66462dee4
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 10, 2019

  1. qsynth: use qt5.mkDerivation 

    Fixes

  $ qsynth
  qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
  This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

  Aborted (core dumped)

(Also, take qt5.* attrs as input instead of the whole qt5 attrset itself.)
    @bjornfor
    bjornfor committed Oct 10, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3fc6646 View commit details
Showing with 5 additions and 3 deletions.
  1. +5 −3 pkgs/applications/audio/qsynth/default.nix
8 changes: 5 additions & 3 deletions pkgs/applications/audio/qsynth/default.nix
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{ stdenv, fetchurl, alsaLib, fluidsynth, libjack2, qt5, autoconf, pkgconfig }:
{ stdenv, fetchurl, alsaLib, fluidsynth, libjack2, autoconf, pkgconfig
, mkDerivation, qtbase, qttools, qtx11extras
}:

stdenv.mkDerivation rec {
mkDerivation rec {
pname = "qsynth";
version = "0.5.7";

@@ -11,7 +13,7 @@ stdenv.mkDerivation rec {

nativeBuildInputs = [ autoconf pkgconfig ];

buildInputs = [ alsaLib fluidsynth libjack2 qt5.qtbase qt5.qttools qt5.qtx11extras ];
buildInputs = [ alsaLib fluidsynth libjack2 qtbase qttools qtx11extras ];

enableParallelBuilding = true;