Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meshlab: 20180627-beta -> 20190129-beta #70937

Merged
merged 1 commit into from
Nov 3, 2019
Merged

meshlab: 20180627-beta -> 20190129-beta #70937

merged 1 commit into from
Nov 3, 2019
+84 −44

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 10, 2019 •
edited
Loading

Note this is the backport for release-19.09 (because I tested this first). We may or may not merge this as a backport. See #70973 for the master version.

Motivation for this change

I couldn't get the existing version to run with nix on Ubuntu (it complained about the QT hook stuff from #65399), so I tried to migrate it to the QT mkDerivation from https://hydra.nixos.org/build/96804884/download/1/nixpkgs/manual.html#sec-language-qt; that failed with clang errors, so I tried to upgrade it, that failed with lots of file problems, so I patched it like Arch does.

Now it compiles, but still doesn't run on Ubuntu (same error as #34894), so I can't test it.

But maybe it works on NixOS; I wanted to share the WIP work here. Please somebody try it on NixOS.

Patches Based on Arch Linux versions:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=meshlab-git&id=f7250ea818470f07dc9b86726407091d39c0be6f

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @viric

Sorry, something went wrong.

@nh2 nh2 requested review from viric and chpatrick October 10, 2019 22:02
@nh2 nh2 mentioned this pull request Oct 10, 2019
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 10, 2019
@nh2
Copy link
Contributor Author

nh2 commented Oct 11, 2019 •
edited
Loading

OK, using the standard instructions from https://github.com/guibou/nixGL I actually got this to run on my Ubuntu 18.04 on my Intel-only Thinkpad:

nixGLIntel meshlab

I'll remove the WIP.

@nh2 nh2 changed the title WIP: meshlab: 20180627-beta -> 20190129-beta meshlab: 20180627-beta -> 20190129-beta Oct 11, 2019
@nh2
Copy link
Contributor Author

nh2 commented Oct 11, 2019

@GrahamcOfBorg build

This was referenced Oct 11, 2019
Open
Merged
Closed
@nh2
Copy link
Contributor Author

nh2 commented Oct 30, 2019

I've made some improvements on #70973, those should be merged first and then reflected back here.

@nh2
meshlab: 20180627-beta -> 20190129-beta.
1fd6f4c 
Patches Based on Arch Linux versions:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=meshlab-git&id=f7250ea818470f07dc9b86726407091d39c0be6f

Also added more comments.

(cherry picked from commit f50fca7)
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
@nh2 nh2 force-pushed the meshlab-20190129 branch from d45b00b to 1fd6f4c Compare November 1, 2019 01:33
@nh2
Copy link
Contributor Author

nh2 commented Nov 1, 2019

Rebased for #70973 merge.

@GrahamcOfBorg build

@nh2 nh2 merged commit 6ca8aa0 into NixOS:release-19.09 Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric

@chpatrick chpatrick

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nh2