Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cawbird: 1.0.1 -> 1.0.2 #70935

Merged
merged 1 commit into from Oct 11, 2019
Merged

cawbird: 1.0.1 -> 1.0.2 #70935

merged 1 commit into from Oct 11, 2019

Conversation

schmittlauch
Copy link
Member

Motivation for this change

fixes some TLS connection issues
please backport to release-19.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jonafato October 10, 2019 22:31
jonafato
jonafato approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jonafato jonafato left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work for me 👍.

worldofpeace
worldofpeace suggested changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit message should be cawbird: 1.0.1 -> 1.0.2 as per the contribution guidelines on commit messages.

Otherwise should be fine 👍

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 11, 2019
@schmittlauch
cawbird: 1.0.1 -> 1.0.2
b4c6764 
fixes some TLS connection issues
@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build cawbird

@ofborg ofborg bot requested a review from jonafato October 11, 2019 07:24
@worldofpeace worldofpeace changed the title cawbird: bump version to 1.0.2 cawbird: 1.0.1 -> 1.0.2 Oct 11, 2019
@worldofpeace worldofpeace merged commit 61817ae into NixOS:master Oct 11, 2019
@worldofpeace
Copy link
Contributor

backported in 5d430d1

@schmittlauch schmittlauch deleted the cawbird-1.0.2 branch October 11, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schmittlauch @worldofpeace @jonafato @jonringer