Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome 3.34.1 staging #71022

Merged
merged 8 commits into from Oct 15, 2019
Merged

Gnome 3.34.1 staging #71022

merged 8 commits into from Oct 15, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Oct 12, 2019

Motivation for this change

Update glib gtk et. al.

Things done

Built the derivations against master.

Notify maintainers

cc @

@hedning
Copy link
Contributor Author

hedning commented Oct 12, 2019

Changelogs (made with https://github.com/jtojnar/what-changed/):

8ded001947fe993654a511b9ded070b6a5a9edb3: gdk-pixbuf: 2.38.2 -> 2.46.0
2.40.0 (stable)
===

  - Allow creating a GdkPixbuf instance without any property [Federico Mena
    Quintero, #91]
	
	
c7b15aa3fb85defa487772fb2e2013ffd1611bf8: libsoup: 2.68.1 -> 2.68.2
Changes in libsoup from 2.68.1 to 2.68.2:

        * Documentation fixes [Sonny Piers]

        * Windows compatibility test fixes [Ignacio Casal Quinteiro]

        * WebSockets: client_max_window_bits in server must have a value [Carlos Garcia Campos]
        * build: improve diagnostics when detecting Apache [Simon McVittie]

        * NTLM: Make v2 authentication more robust [Claudio Saavedra]

        * Updated translations: British English, Chinese (Taiwan), Danish, Dutch
	
	
05d393e7594f1a0c891f5858f354bb3610aca51e: librsvg: 2.46.0 → 2.46.1
Version 2.46.1
- #506 - Fix empty patterns which reference a fallback pattern with
  children.
	
	
8159245cb89bcf6c6c7408ed59aab4c3abaee72d: gtk3: 3.24.11 → 3.24.12
Overview of Changes in GTK+ 3.24.12
===================================

* file chooser: allow sorting by file type

* dnd: fix pointer offsets under X11 and Wayland

* broadway: Fix a font problem

* mir Drop this backend

* printing: Get PPD from original host if needed

* a11y: Fix interference with clutter a11y impl

* Translation updates:
  Brazilian Portuguese
  Czech
  Danish
  Dutch
  Italian
  Greek
  Lithuanian
  Norwegian Bokmål
  Polish
  Romanian
  Slovenian
  Spanish
  Turkish
	
	
	
f0b89403c475a5355e1a833561d96cc2ac1e3d6f: glib-networking: 2.62.0 → 2.62.1
2.62.1 - October 4, 2019
========================

- Fix two memory leaks (!71, !72, Claudio Saavedra)
	
	
02b966ab9271999b0333f60f7095aebffa813b0e: glib: 2.62.0 → 2.62.1
Overview of changes in GLib 2.62.1
==================================

* Fix regression in g_file_copy() when passing
  `G_FILE_COPY_TARGET_DEFAULT_PERMS` flag; the destination permissions would be
  private rather than following the process’ umask (!1142)

* Several `GDateTime` parsing fixes (!1127)

* Always build the tests if installed-tests are enabled, so that the tests can
  actually be installed (!1141)

* Bugs fixed:
  - #174 g_file_copy always preserves  permissions, even if G_FILE_COPY_ALL_METADATA flag is not set
  - #1865 g_variant_get_data_as_bytes fails after serializing a variant
  - #1875 Segfault and Overflow in __gio_xdg_cache_mime_type_subclass() with Wps-Office installed
  - #1887 glib 2.62.0 breaks loading dylibs as modules
  - #1888 2.62: docs build on Windows broken
  - !1021 docs: Remove priv pointers from the tutorial example
  - !1094 Backport to 2.62: gmodule: use dl implementation on macOS
  - !1101 Backport !1092 “Fix doc build on Windows” to glib-2-62
  - !1102 Backport !1080 “tests: Fix skipping mkdir-with-parents-permission test” to glib-2-62
  - !1103 Backport !1085 “xdgmime: Prevent infinite loops from badly-formed MIME registrations” to glib-2-62
  - !1127 Backport !1125 and !1115 GDateTime parsing fixes to glib-2-62
  - !1128 Backport !1043 “gvariant: Handle empty serialisations in get_child_value()” to glib-2-62
  - !1140 [2.62] g_file_info_get_modification_date_time: Calculate in integer domain
  - !1141 [2.62] Always build tests if we enabled installed-tests
  - !1142 Backport !1134 Fix for file copy permissions to glib-2-62

* Translation updates:
  - Danish
  - Italian
  - Panjabi
  - Serbian
  - Turkish

jtojnar
jtojnar approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes and changelogs look good

@hedning
Copy link
Contributor Author

hedning commented Oct 12, 2019

Missed an obsolete patch in gtk3 (wasn't in master so my build didn't catch it).

@ofborg ofborg bot requested a review from jtojnar October 12, 2019 14:46
@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 12, 2019 •
edited

I think I'll update gtk-doc as well

IIRC all the mess with the prior releases should be cleaned up now.

Should also double check there's no reported issues against the meson build in gtk3.

@worldofpeace
gtk-doc: 1.30 -> 1.32
f03b26c 
Drop patch for "Wrong permissions for style CSS file".
It was fixed in 1.31

https://gitlab.gnome.org/GNOME/gtk-doc/blob/GTK_DOC_1_32/NEWS
@worldofpeace
Copy link
Contributor

With f03b26c tested building glib's docs and viewed them.
Though I do believe I reverted a commit in networkmanager that was for latest gtk-doc so we need to merge #71011 also.

@ofborg ofborg bot requested a review from pSub October 12, 2019 21:47
@vcunat
Copy link
Member

vcunat commented Oct 13, 2019

Side note: if you work on these, you might be interested also in 5e9bf0f0

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 13, 2019 •
edited

Side note: if you work on these, you might be interested also in 5e9bf0f

It's used for pkgconfig

so I guess I'll move it to nativeBuildInputs.
I presume master has already been merged into staging?

Edit: did this in 1905ae3

worldofpeace referenced this pull request Oct 13, 2019
@worldofpeace
gnome3.tracker: move dbus to nativeBuildInputs
1905ae3
@worldofpeace
gtk: reorganize
082b0b2 
This directory was mess of patches and hooks.
Have a patches dir and a setup-hooks dir.
@hedning hedning merged commit 9752932 into NixOS:staging Oct 15, 2019
@hedning
Copy link
Contributor Author

hedning commented Oct 15, 2019

Took a last pass over issues and commits in upstream for glib and gtk3. Nothing that really popped out.

@hedning hedning deleted the gnome-3.34.1-staging branch October 15, 2019 11:25
@hedning hedning mentioned this pull request Oct 15, 2019
Merged
10 tasks
@hedning
Copy link
Contributor Author

hedning commented Oct 17, 2019 •
edited

glib fails to build on darwin. Disabling docs makes it build #71289, looking at the commits in glib-2.62.1, which aren't many, I'd hazard a guess that the newer gtk-doc is causing the issue.

@worldofpeace
Copy link
Contributor

Pretty much expect gtk-doc releases to break something, though I did caution to test glib docs because of last release, though just not on darwin 😄

#71221 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@edolstra edolstra Awaiting requested review from edolstra

@lovek323 lovek323 Awaiting requested review from lovek323

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@jtojnar jtojnar Awaiting requested review from jtojnar

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hedning @worldofpeace @vcunat @jtojnar