Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datadog-agent: 6.11.2 -> 6.14.0 #68933

Closed
wants to merge 2 commits into from
Closed

datadog-agent: 6.11.2 -> 6.14.0 #68933

wants to merge 2 commits into from
+79 −33

Conversation

cransom
Copy link
Contributor

@cransom cransom commented Sep 16, 2019

Motivation for this change

Update for new features in datadog-agent

Things done

bumped version info, updated go deps, and removed a file copy operation since the source no longer exists in the repository and everything still seems to work as it should. I've marked as broken on darwin since systemd is a buildInput and has been since this package was introduced, but it should be able to be optional.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @domenkozar @rvl

Sorry, something went wrong.

Casey Ransom added 2 commits September 16, 2019 14:22
datadog-agent: 6.11.2 -> 6.14.0
50ac699
datdog-agent: broken on darwin
a919892 
With the buildInput requiring systemd, this does not build cleanly on
macOS.
@cransom cransom changed the title Datadog update datadog-agent: 6.11.2 -> 6.14.0 Sep 16, 2019
rvl
rvl approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@cransom
Copy link
Contributor Author

cransom commented Sep 17, 2019 •
edited
Loading

I'll ask to hold off on merging this for the moment. After some more testing on a local deployment, it seems the trace agent stopped working.

I take it back. I was seeing an additional integration error message in datadog but that's due to the default conf.d files we copy over that, as default, trigger an error and don't do anything else really. I validated that process monitoring and trace logs still work normally. I'll have a follow up patch outside of this PR that cleans those out as we really don't need to include a windows process check.

@cransom
Copy link
Contributor Author

cransom commented Oct 10, 2019

i've found some odd behavior with the integrated checks in further testing. i'll resubmit when this is really ironed out.

@cransom cransom closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cransom @rvl