Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.lazy_import: init at 0.2.2 #70921

Merged
merged 4 commits into from May 25, 2020
Merged

pythonPackages.lazy_import: init at 0.2.2 #70921

merged 4 commits into from May 25, 2020

Conversation

marenz2569
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@risicle
Copy link
Contributor

risicle commented Oct 10, 2019

The automatic test runner isn't finding anything - you need to add a custom checkPhase:

  checkPhase = ''
    cd lazy_import
    pytest --boxed
  '';

@doronbehar
Copy link
Contributor

Squash your commits and I'll approve.

@Mic92
Copy link
Member

Mic92 commented May 23, 2020

Result of nixpkgs-review pr 70921 1

2 packages built:
- python27Packages.lazy_import
- python37Packages.lazy_import

@Mic92
Copy link
Member

Mic92 commented May 24, 2020

Result of nixpkgs-review pr 70921 1

3 packages built:
- python27Packages.lazy_import
- python37Packages.lazy_import
- python38Packages.lazy_import

@Mic92 Mic92 merged commit 7915115 into NixOS:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marenz2569 @risicle @doronbehar @Mic92 @jonringer