[tools] Correctly infer base rev in pull requests #19650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "before" property is only present in the "Push" GitHub Event. When building for a pull request, derive the base revision from the "base" property of the pull request object [2]. [1] https://developer.github.com/v3/activity/events/types/#pushevent [2] https://developer.github.com/v3/pulls/
foolip
approved these changes
Oct 11, 2019
|
We could also just move the rules for what files should trigger the workflow to the yml files, now that GitHub Actions supports that. Any reason to continue doing it ourselves? |
|
Excellent idea. It makes our code simpler and avoids running the GitHub Actions infrastructure only to immediately exit. Let's do that instead: gh-19652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "before" property is only present in the "Push" GitHub Event. When
building for a pull request, derive the base revision from the "base"
property of the pull request object [2].
[1] https://developer.github.com/v3/activity/events/types/#pushevent
[2] https://developer.github.com/v3/pulls/