Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rpyc: enable tests #71003

Merged
merged 1 commit into from Oct 27, 2019
Merged

pythonPackages.rpyc: enable tests #71003

merged 1 commit into from Oct 27, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 11, 2019 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-16328

This was originally a security bump of 4.1.1 -> 4.1.2, but that got superseded. Now this is just about the enabling of the tests that I did at the same time....

Noticed that the tests weren't actually running or present in the pypi tarball, so switched to the github source and fixed up their execution.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle risicle requested a review from FRidh as a code owner October 11, 2019 23:16
@risicle risicle changed the title pythonPackages.rpyc: 4.1.1 -> 4.1.2, fixing CVE-2019-16328 pythonPackages.rpyc: enable tests Oct 27, 2019
@risicle
Copy link
Contributor Author

risicle commented Oct 27, 2019

@GrahamcOfBorg build python37Packages.rpyc python38Packages.rpyc

jonringer
jonringer approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (2 failures on master)
diff LGTM

[0 built (2 failed)]
error: build of '/nix/store/w87lwcd2knpja4xxvsg27fld8bqclw4x-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71003
2 package failed to build:
flexget python38Packages.rpyc

2 package were build:
python27Packages.rpyc python37Packages.rpyc

thanks for enabling tests! :)

@jonringer
Copy link
Contributor

the failure for python38 needs to be handled upstream

builder for '/nix/store/93x9y6yjv4r3alcwdl5maz43admsx9q7-python3.8-rpyc-4.1.2.drv' failed with exit code 1; last 10 log lines:
      codeobj = _import_codetup(codetup)
    File "/nix/store/c1lv2w2fnmjdcnbl1mdvp2vhfvqrjsg4-python3.8-rpyc-4.1.2/lib/python3.8/site-packages/rpyc/utils/teleportation.py", line 125, in _import_codetup
      return CodeType(argcnt, kwargcnt, nloc, stk, flg, codestr, tuple(consts2), names, varnames, filename, name,
  TypeError: an integer is required (got type bytes)


  ----------------------------------------------------------------------
  Ran 57 tests in 31.582s

  FAILED (SKIP=6, errors=3)
cannot build derivation '/nix/store/w87lwcd2knpja4xxvsg27fld8bqclw4x-env.drv': 2 dependencies couldn't be built

@jonringer jonringer merged commit e5f671a into NixOS:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer