networkmanager: fix udev rule warning #71001
Closed
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
requested review from
basvandijk,
FRidh,
infinisil,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
rycee,
thoughtpolice and
ttuegel
as code owners
ofborg
bot
added
6.topic: erlang
6.topic: GNOME
Apply upstream patch to fix an annoying warning:
/nix/store/hj3g05ypn2a6iwd1qdv8cysbbkhp1apj-udev-rules/84-nm-drivers.rules:10 Invalid value "/nix/store/l6h4ya0wzb4b8mr0y58k2gh2nhfql4sn-bash-4.4-p23/bin/bash -c '/nix/store/qv79j3glsdmfhdzwjwa5ys3s7k0kary5-ethtool-5.2/bin/ethtool -i $1 | /nix/store/5pwj1q9zbs89xv9wlmp554p4fixz9im4-gnused-4.7/bin/sed -n s/^driver:\ //p' -- $env{INTERFACE}" for PROGRAM (char 142: invalid substitution type), ignoring, but please fix it.
jtojnar
force-pushed
the
nm-fix-udev-rule
branch
from
bf7e53c to
eb109ef
Compare
|
Never mind, this is already part of NM 1.20.2 we have on staging (https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/abd1e1e0902174d19eaaedc349a0082aff5572d9). |
That's still not merged? I'm confused as to what's going on with the staging workflow, I could've swore the last merge should have landed that. |
|
Seems to have been merged again at fda4a08 just not with a PR. |
|
There probably was not a staging branch-off in between. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply upstream patch to fix an annoying warning: