Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diceware: add missing 'setuptools' to propagatedBuildInputs #70912

Merged
merged 1 commit into from Oct 10, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Oct 10, 2019

(cherry picked from commit f641fca)

Motivation for this change

Currently fails with:

[grahamc@Petunia:~]$ nix-shell -p diceware --run diceware
Traceback (most recent call last):
  File "/nix/store/izqgibxvwydd4yg29p2hym1zsfq4sxfy-diceware-0.9.6/bin/.diceware-wrapped", line 7, in <module>
    from diceware import main
  File "/nix/store/izqgibxvwydd4yg29p2hym1zsfq4sxfy-diceware-0.9.6/lib/python2.7/site-packages/diceware/__init__.py", line 19, in <module>
    import pkg_resources
ImportError: No module named pkg_resources
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from asymmetric October 10, 2019 13:59
@grahamc grahamc merged commit 654a95b into NixOS:release-19.09 Oct 10, 2019
@grahamc grahamc deleted the backport-diceware-fix branch October 10, 2019 14:16
@druimalban
Copy link
Contributor

Can confirm this fixes the issue on darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants