Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate pregenerated certs #19626

Merged
merged 2 commits into from Oct 14, 2019
Merged

Regenerate pregenerated certs #19626

merged 2 commits into from Oct 14, 2019

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Oct 10, 2019 •
edited

We've needed to do this since 2cccd82, but haven't. Whoops.

@gsnedders gsnedders mentioned this pull request Oct 10, 2019
Closed
@gsnedders
Copy link
Member Author

Failing on macOS:

SecCertificateCreateFromData: Unknown format in import.
Error reading file tools/certs/cacert.pem

@wpt-pr-bot wpt-pr-bot added the ci label Oct 14, 2019
@gsnedders
Copy link
Member Author

(I on the whole don't think we should land this hack, but… we should see if it works on CI at least)

@gsnedders
Regenerate pregenerated certs
174b8cf 
We've needed to do this since 2cccd82, but haven't. Whoops.

This also stops outputting the text form of the certificate before the
PEM header as macOS/iOS's Security.framework only scans the first 8192
characters for the beginning of the header.
@gsnedders
Readd documentation on how to generate pregenerated certs
186d18f 
This accidentally got removed in afd4200.
@gsnedders
Copy link
Member Author

@jgraham can you re-review this?

@jgraham jgraham merged commit b88d541 into web-platform-tests:master Oct 14, 2019
@gsnedders gsnedders deleted the update_certs_20191010 branch October 14, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jgraham jgraham

Labels
certs ci infra wptserve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gsnedders @jgraham @wpt-pr-bot