Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/python: clarify python nix tooling efforts #71053

Merged
merged 1 commit into from Oct 14, 2019
Merged

doc/python: clarify python nix tooling efforts #71053

merged 1 commit into from Oct 14, 2019

Conversation

ariutta
Copy link
Contributor

@ariutta ariutta commented Oct 12, 2019

Motivation for this change

It appears @garbas forked offlinehacker/pypi2nix to garbas/pypi2nix and then handed off maintainership to @seppeljordan, transferring the repo to nix-community/pypi2nix.

Things done

I removed offlinehacker/pypi2nix as an unmaintained ancestor of the current repo nix-community/pypi2nix, updated garbas/pypi2nix to nix-community/pypi2nix and clarified the relationship between pypi2nix and nixpkgs derivatives.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @garbas and @seppeljordan

@ariutta
Update python.section.md Tools
40e15d2 
@garbas and @seppeljordan, are these updates correct?

I removed `offlinehacker/pypi2nix` as an unmaintained ancestor of the current repo `nix-community/pypi2nix`. It appears @garbas forked `offlinehacker/pypi2nix` to `garbas/pypi2nix` and then handed off maintainership to @seppeljordan, transferring the repo to `nix-community/pypi2nix`.
@ariutta ariutta requested a review from FRidh as a code owner October 12, 2019 20:14
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 12, 2019
@worldofpeace
Copy link
Contributor

Can you update your commit message to match the contribution guidelines?
So like doc/python: clarify python nix tooling efforts.

@ariutta ariutta changed the title Update python.section.md Tools doc/python: clarify python nix tooling efforts Oct 12, 2019
@FRidh
Copy link
Member

FRidh commented Oct 14, 2019

please update the commit title, not just the PR title.

@Mic92 Mic92 merged commit 1f7b1cf into NixOS:master Oct 14, 2019
@Mic92
Copy link
Member

Mic92 commented Oct 14, 2019

Fixed commit title while squashing. I suppose we should backport this as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: documentation 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ariutta @worldofpeace @FRidh @Mic92 @garbas