Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PR #64267, add missing release notes and documentation [19.09] #71056

Closed
wants to merge 2 commits into from
Closed

Update to PR #64267, add missing release notes and documentation [19.09] #71056

wants to merge 2 commits into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Oct 12, 2019 •
edited

Motivation for this change

Backport of #70887 for the 19.09 release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tokudan
Update to PR NixOS#64267, add missing release notes.
df208d1 
(cherry picked from commit 8a2555132e0afeded544e90cc3990fab0c63093a)
@tokudan
doc: Add documentation for the new option to the Automatic Upgrades s…
8328b04 
…ection

(cherry picked from commit a223335d8a6f076538a0b5e340025c89fe8ee7db)
@tokudan tokudan mentioned this pull request Oct 12, 2019
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/13

@tokudan
Copy link
Contributor Author

tokudan commented Feb 8, 2020

Closing as it seems unlikely anyone will care.

@tokudan tokudan closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tokudan @nixos-discourse