Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdoc: 1.4 -> 1.5 #71057

Merged
merged 1 commit into from Nov 14, 2019
Merged

renderdoc: 1.4 -> 1.5 #71057

merged 1 commit into from Nov 14, 2019

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Oct 12, 2019 •
edited

Motivation for this change

Upstream version update + added OpenGL RUNPATH fix + overall cleanup

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@multun
Copy link
Member

multun commented Oct 21, 2019

LGTM, tested with sandboxing

This was referenced Oct 25, 2019
Closed
Closed
c0bw3b
c0bw3b approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs (both qrenderdoc and renderdoccmd)

Result of nix-review pr 71057 1

1 package were build:
  • renderdoc

@c0bw3b c0bw3b merged commit df7cdb3 into NixOS:master Nov 14, 2019
c0bw3b pushed a commit that referenced this pull request Nov 14, 2019
@jansol @c0bw3b
renderdoc: 1.4 -> 1.5
872b6a2 
Backport of #71057
Close #71961

(cherry picked from commit 392b36c)
@c0bw3b c0bw3b added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@multun multun multun approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: documentation 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jansol @multun @Ralith @c0bw3b