Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scummvm: 2.0.0 -> 2.1.0 #71054

Merged
merged 1 commit into from Oct 15, 2019
Merged

scummvm: 2.0.0 -> 2.1.0 #71054

merged 1 commit into from Oct 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2019

Motivation for this change

Version bump. Needs curl for new cloud saving feature.

dontDisableStatic flag is added since the ./configure script didn't recognize --disable-static flag added by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg

scummvm: 2.0.0 -> 2.1.0
2753998 
Needs curl for cloud saving support.

dontDisableStatic flag is added since the ./configure script didn't
recognize --disable-static flag added by default.
@ofborg ofborg bot requested a review from peterhoeg October 12, 2019 20:39
@globin
Copy link
Member

globin commented Oct 15, 2019

@GrahamcOfBorg build scummvm

@globin globin merged commit e05e991 into NixOS:master Oct 15, 2019
@ghost ghost deleted the patch-1 branch October 16, 2019 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@globin