VM test closure checks #70981
VM test closure checks #70981
Conversation
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
Do we still care about this? Seems like it might be useful to include in the upcoming release. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
edolstra
removed
the
2.status: stale
stale
bot
added
the
2.status: stale
|
Is there something I can do to help with getting this PR merged? |
| @@ -410,6 +410,27 @@ in | |||
| ''; | |||
| }; | |||
|
|
|||
| # FIXME: should move this to top-level.nix. | |||
| system.forbiddenDependencies = mkOption { | |||
There was a problem hiding this comment.
i'll split this in to a separate pr and address the FIXME
stale
bot
removed
the
2.status: stale
| # Ensure that NixOS configurations don't have -dev paths | ||
| # or gcc.out in their closures. | ||
| system.forbiddenDependencies = mkDefault "(-dev$)|(-gcc-[0-9\.]+$)|(gcc-wrapper)"; | ||
| system.maxClosureSize = mkDefault (1024 * 1024 * 1024); |
There was a problem hiding this comment.
Based on my experience with GHC, it will be the tests on ARM that run into such a check first.
Those are may be undermaintained, so they'd (wrongly) end up in the bag of tests considered flaky, so I wouldn't want to burden all tests with a (default) closure size check. Instead, we could check some key services or even just the empty NixOS on a single, popular system, such as x86_64-linux. (e.g. nixosTests.empty-system-closure-size, so the problem can be spotted at a glance)
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
This adds checks to ensure that the
config.system.build.toplevelderivation of a VM does not have-devoutputs orgccin its closure, and that the size of the closure is not unexpectedly high. (The default is 1 GiB, but this can be overriden per test.)