Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord-canary: 0.0.96 -> 0.0.98 (backport) #70979

Merged
merged 3 commits into from Nov 23, 2019
Merged

discord-canary: 0.0.96 -> 0.0.98 (backport) #70979

merged 3 commits into from Nov 23, 2019

Conversation

tadeokondrak
Copy link
Member

@tadeokondrak tadeokondrak commented Oct 11, 2019 •
edited

Motivation for this change

Discord does not launch if not kept up to date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tadeokondrak
discord-canary: 0.0.96 -> 0.0.97
d50afea 
(cherry picked from commit 64ccc04)
@tadeokondrak
maintainers/scripts/update-discord: improve
1cb5b33 
- add comment specifying file is generated
- remove repetition of version number

(cherry picked from commit ad6e1e4)
@tadeokondrak
discord-canary: 0.0.97 -> 0.0.98
4ac29c3 
(cherry picked from commit 2e6498332463c435076878be2f9685db22cdb00e)
@tadeokondrak tadeokondrak changed the title discord-canary: 0.0.96 -> 0.0.97 (backport) discord-canary: 0.0.96 -> 0.0.98 (backport) Nov 14, 2019
c0bw3b
c0bw3b approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b c0bw3b merged commit 1b94210 into NixOS:release-19.09 Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tadeokondrak @c0bw3b