Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pivx: 3.2.0 -> 3.4.0 #71025

Merged
merged 1 commit into from Oct 13, 2019
Merged

pivx: 3.2.0 -> 3.4.0 #71025

merged 1 commit into from Oct 13, 2019

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Oct 12, 2019 •
edited

  • pivx: 3.2.0 -> 3.2.2

  • altcoins.pivx: 3.2.2 -> 3.3.0

Furthermore, this fixes 2542928

  • pivx: 3.3.0 -> 3.4.0

Added test_pivx as test ran by nixpkgs

  • Update pkgs/applications/blockchains/pivx.nix

Thanks to @Lassulus for fixing this typo!

Co-Authored-By: Lassulus github@lassul.us

Backport of #67412
@Lassulus maybe you can nix-review this shortly? I'm currently on a weak laptop and don't have the time to compile.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Lassulus

@Lassulus
Copy link
Member

did you use git cherry-pick -x ?

@wucke13
Copy link
Contributor Author

wucke13 commented Oct 12, 2019

without -x, namely git cherry-pick e9cd8a2d60f0fb1a55b997a3f10aefdd1f1b1e52

@Lassulus
Copy link
Member

ah, normally we use -x to show the original commit which is cherry picked. There is a section in the manual about this: https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

@wucke13
pivx: 3.2.0 -> 3.4.0
ef5d6b8 
* pivx: 3.2.0 -> 3.2.2

* altcoins.pivx: 3.2.2 -> 3.3.0

Furthermore, this fixes 2542928

* pivx: 3.3.0 -> 3.4.0

Added `test_pivx` as test ran by nixpkgs

* Update pkgs/applications/blockchains/pivx.nix

Thanks to @Lassulus for fixing this typo!

Co-Authored-By: Lassulus <github@lassul.us>
(cherry picked from commit e9cd8a2)
@wucke13
Copy link
Contributor Author

wucke13 commented Oct 12, 2019 •
edited

Ah ok. Didn't knew that. I adjusted accordingly and force-pushed 😄

Lassulus
Lassulus approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, on top of 19.09

@Lassulus Lassulus merged commit 41380a2 into NixOS:staging-19.09 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wucke13 @Lassulus