Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc-8.8.x: jailbreak io-streams-haproxy #71027

Merged
merged 1 commit into from Oct 14, 2019
Merged

ghc-8.8.x: jailbreak io-streams-haproxy #71027

merged 1 commit into from Oct 14, 2019

Conversation

turboMaCk
Copy link
Member

io-streams-haproxy build was failing due to overly restrictive uper bounds package versions. Tests are passing with just simple jailbreak.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@peti peti force-pushed the haskell-updates branch 2 times, most recently from 407ecc3 to 33366cc Compare October 13, 2019 12:27
@turboMaCk
Copy link
Member Author

rebased after the force push to base branch.

@cdepillabout
Copy link
Member

@turboMaCk Could you report this upstream, and then add a comment and a link to the upstream issue/PR in the configuration-ghc-8.8.x.nix file? This will help the nixpkgs maintainers know when the jailbreak can be removed.

@turboMaCk
Copy link
Member Author

sure will do @cdepillabout. PLS wait with merge until the furher notice

@turboMaCk
Copy link
Member Author

@cdepillabout it should be done. Thanks for the good point I will be adding this to all similar PRs going forward. Let me know if there is something else I can do. Also I don't think this merge is supper important so we can wait until upstream accepts the change as well if you wish.

@cdepillabout
Copy link
Member

@turboMaCk Thanks!

@peti This should be ready to merge.

Or, like @turboMaCk says, we can just wait for snapframework/io-streams-haproxy#17 to be merged, which should fix this. Then we could just close this PR.

@peti peti merged commit 4a9845e into NixOS:haskell-updates Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turboMaCk @cdepillabout @peti