Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.bokeh: added packaging dependency #71024

Merged
merged 1 commit into from Oct 12, 2019

Conversation

marcus7070
Copy link
Member

Motivation for this change

Previously Bokeh would build and pass tests, but import bokeh.plotting would fail with

  File "/nix/store/d7rlq9db362d9zgvrd0rb9x0bhzp0p03-python3.7-bokeh-1.3.4/lib/python3.7/site-packages/bokeh/util/dependencies.py", line 28, in <module>
    from packaging.version import Version as V
ModuleNotFoundError: No module named 'packaging'

Note that packaging is in Bokeh's requirements, and here is the commit that introduced it.

Things done

Just added packaging to propagatedBuildInputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'm inexperienced at all this stuff, sorry if I got anything wrong.

Notify maintainers

cc @

@flokli
Copy link
Contributor

flokli commented Oct 12, 2019

Thanks!

@marcus7070 marcus7070 deleted the marcus7070/bokeh-fix branch October 13, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants