Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

managesieve: init at 0.6 #71028

Merged
merged 2 commits into from Oct 20, 2019
Merged

managesieve: init at 0.6 #71028

merged 2 commits into from Oct 20, 2019

Conversation

dadada
Copy link
Contributor

@dadada dadada commented Oct 12, 2019 •
edited

Motivation for this change

Add managesieve python library and sieveshell script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @htgoebel

@dadada dadada requested a review from FRidh as a code owner October 12, 2019 11:40
@dadada dadada changed the title init: managesieve at 0.6 managesieve: init at 0.6 Oct 12, 2019
@dadada dadada force-pushed the dadada/managesieve branch 2 times, most recently from 2ffddc1 to 3babcf3 Compare October 13, 2019 08:20
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

jonringer
jonringer approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (python38 broken due to dependency broken (pytest))
diff LGTM
executable seems to work
leaf package

[3 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/ydvfxh1lvfyjr73z03a4nzads55sv0c3-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71028
1 package failed to build:
python38Packages.managesieve

2 package were build:
python27Packages.managesieve sieveshell

[nix-shell:/home/jon/.cache/nix-review/pr-71028]$ nix path-info -Sh ./results/python27Packages.managesieve
/nix/store/jdq5hlyfj8z36m48akagx1r3m802bzcz-python2.7-managesieve-0.6     93.7M

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.managesieve sieveshell

@jonringer
Copy link
Contributor

oops, looks like I forgot to push the button, thanks for staying through all the revisions :)

@jonringer jonringer merged commit e30988e into NixOS:master Oct 20, 2019
@htgoebel
Copy link

Congratulations and Thanks. AFAIK NixOs is the first distribution to integrate my managesieve.

@dadada dadada deleted the dadada/managesieve branch March 30, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dadada @jonringer @htgoebel @teto