node updater improvements #70974
Merged
node updater improvements #70974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teto
force-pushed
the
nodegenerate
branch
2 times, most recently
from
6128b56
to
711e245
Compare
|
(triage) ping |
|
rebased |
Profpatsch
requested changes
Jan 28, 2020
Profpatsch
reviewed
Jan 29, 2020
| node2nix --nodejs-10 -i node-packages-v10.json -o node-packages-v10.nix -c composition-v10.nix | ||
| node2nix --nodejs-12 -i node-packages-v12.json -o node-packages-v12.nix -c composition-v12.nix | ||
| node2nix --nodejs-13 -i node-packages-v13.json -o node-packages-v13.nix -c composition-v13.nix | ||
| cd "$NODE_NIXPKGS_PATH/pkgs/development/node-packages" |
There was a problem hiding this comment.
Did you know you can have the current path in nix?
let here = toString ./.;
You don’t have to do any tmpdir/cd magic, just use here as an absolute path.
There was a problem hiding this comment.
try it out with nix-instantiate --eval -E 'toString ./.'.
There was a problem hiding this comment.
the tmpdir magic is in order to not break nixpkgs if something goes wrong during evaluation (which happens if your network is unstable for instance)
There was a problem hiding this comment.
I’d argue that’s what git is for, but I’m fine with the code as it stands.
- Make it run from anywhere - overwrite old packages only on success to prevent getting into a bad state
Profpatsch
approved these changes
Feb 4, 2020
This was referenced Mar 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @