Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meshlab: 20180627-beta -> 20190129-beta #70973

Merged
merged 1 commit into from
Nov 1, 2019
Merged

meshlab: 20180627-beta -> 20190129-beta #70973

merged 1 commit into from
Nov 1, 2019
+84 −44

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 11, 2019 •
edited
Loading

Motivation for this change

See #70937 (backport to release-19.09 which I wrote first) for all details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @viric

Sorry, something went wrong.

@nh2 nh2 requested a review from chpatrick October 11, 2019 12:47
@nh2 nh2 mentioned this pull request Oct 11, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from viric October 11, 2019 13:01
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 11, 2019
@nh2 nh2 force-pushed the meshlab-20190129-master branch from 6682580 to f50fca7 Compare October 30, 2019 11:39
@nh2
Copy link
Contributor Author

nh2 commented Oct 30, 2019

@GrahamcOfBorg build

@nh2
Copy link
Contributor Author

nh2 commented Oct 30, 2019

@f--t Thanks for your review, I've addressed all your comments.

@nh2 nh2 merged commit 73c71dd into NixOS:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f--t f--t

@chpatrick chpatrick

@viric viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @chpatrick @f--t