Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tflint: 0.12.0 -> 0.12.1 #71035

Merged
merged 1 commit into from Oct 22, 2019
Merged

tflint: 0.12.0 -> 0.12.1 #71035

merged 1 commit into from Oct 22, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 12, 2019

Motivation for this change

Changelog: https://github.com/wata727/tflint/releases/tag/v0.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit October 12, 2019 14:29
@Ma27
Copy link
Member

Ma27 commented Oct 12, 2019

Build fails for me with the following issue:

tflint> installing
hash mismatch in fixed-output derivation '/nix/store/fk4ryzv2qbg6sxxy718vvbvz11hdvh0x-tflint-0.12.1-go-modules':
  wanted: sha256:0adxqx4v3vasfhkfmc5h3l4f6fsxi1xp9h5p2xbgrqc256ix7hv9
  got:    sha256:1k920ibxszm969z3bmbsaf9a28i49jhylpwcl52cifqkd6nx93k5
cannot build derivation '/nix/store/dk0kvqiwyra6nsmmzangfbzmnyanp622-tflint-0.12.1.drv': 1 dependencies couldn't be built

@marsam
Copy link
Contributor Author

marsam commented Oct 12, 2019

@Ma27 thanks for testing it, somehow buildGoModule
is generating a different hash with Go 1.13 #71049

@marsam marsam merged commit 62e5aa3 into NixOS:master Oct 22, 2019
@marsam marsam deleted the update-tflint branch October 22, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @Ma27