Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify-tui: init at 0.5.0 #71033

Merged
merged 2 commits into from Oct 12, 2019
Merged

spotify-tui: init at 0.5.0 #71033

merged 2 commits into from Oct 12, 2019

Conversation

jwijenbergh
Copy link
Contributor

Motivation for this change

Spotify-tui is a spotify terminal client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jwijenbergh jwijenbergh changed the title init: spotify-tui at 0.5.0 spotify-tui: init at 0.5.0 Oct 12, 2019
@joachifm
Copy link
Contributor

joachifm commented Oct 12, 2019 •
edited

@GrahamcOfBorg build spotify-tui

@Ma27
Copy link
Member

Ma27 commented Oct 12, 2019 •
edited

Pushed a simple fix for darwin. Let's rebuild...

@GrahamcOfBorg build spotify-tui

@Ma27
Copy link
Member

Ma27 commented Oct 12, 2019

Built and tested on x86_64-linux and x86_64-darwin, so let's merge this now 👍

@Ma27 Ma27 merged commit 1c0e8b7 into NixOS:master Oct 12, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 12, 2019

@jwijenbergh thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jwijenbergh @joachifm @Ma27 @Janik-Haag