Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e169799ca245
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ce0a54092da2
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 12, 2019

  1. Merge #70598: {v8, v8_6_x}: fix log output exceeded w. GCC8 

    (cherry picked from commit 48724c7)
    @joachifm @vcunat
    joachifm authored and vcunat committed Oct 12, 2019
    Copy the full SHA
    ce0a540 View commit details
Showing with 4 additions and 0 deletions.
  1. +4 −0 pkgs/development/libraries/v8/default.nix
4 changes: 4 additions & 0 deletions pkgs/development/libraries/v8/default.nix
View file
Original file line number Diff line number Diff line change
@@ -97,6 +97,10 @@ stdenv.mkDerivation rec {
''v8_snapshot_toolchain="//build/toolchain/linux/unbundle:default"''
] ++ stdenv.lib.optional stdenv.cc.isClang ''clang_base_path="${stdenv.cc}"'';

# with gcc8, -Wclass-memaccess became part of -Wall and causes logging limit
# to be exceeded
NIX_CFLAGS_COMPILE = stdenv.lib.optional stdenv.cc.isGNU "-Wno-class-memaccess";

nativeBuildInputs = [ gn ninja pkgconfig python ]
++ stdenv.lib.optionals stdenv.isDarwin [ xcbuild darwin.DarwinTools ];
buildInputs = [ glib icu ];