Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update elm nodepackages #70962

Merged
merged 1 commit into from Oct 12, 2019
Merged

Update elm nodepackages #70962

merged 1 commit into from Oct 12, 2019

Conversation

BrianHicks
Copy link
Contributor

Motivation for this change

elm-verify-examples 4.0.2 includes a bugfix which I need. Figured I could update it for everyone and save some trouble. 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@BrianHicks
Copy link
Contributor Author

@turboMaCk does this look OK to you?

@BrianHicks
elmPackages.*: update to latest versions
847c5f0 
elm-verify-examples: 4.0.1 -> 4.0.2
elm-live: 4.0.0 -> 4.0.1

downstream dependencies for most packages
@BrianHicks
Copy link
Contributor Author

right, that's all ready to review then :)

turboMaCk
turboMaCk approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@turboMaCk turboMaCk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • builds on nixos
  • binaries work on nixos

Good work, I'm very happy to see more folks using and caring about this 馃憤

LGTM 馃帀

@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages

@domenkozar domenkozar merged commit 407fcf1 into NixOS:master Oct 12, 2019
@BrianHicks BrianHicks deleted the update-elm-nodepackages branch October 12, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar domenkozar left review comments

@turboMaCk turboMaCk turboMaCk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BrianHicks @domenkozar @turboMaCk